Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding full support for txt records #173

Closed
wants to merge 4 commits into from

Conversation

shadtimm
Copy link

@shadtimm shadtimm commented Oct 19, 2021

Add full support for create, update, and delete of txt records using updates to Infoblox GO SDK (using go.mod replace until GO SDK PR merged).

Related issues in this repo:
#89

Related PRs in this repo:
#88 #161

Base code pulled from original PR by @GNewbury1

Updates to align with 2.x provider and comment feedback #88 (comment)

@somashekhar
Copy link
Contributor

Hi @shadtimm ,
Meantime can you also provide us example .tf file used for testing the functionality under https://github.com/infobloxopen/terraform-provider-infoblox/tree/master/examples/v0.14/Resources

@shadtimm
Copy link
Author

shadtimm commented Oct 21, 2021

Hey @somashekhar,
Yes, examples are now pushed up and I updated the tests to better align with the structure of most of the other resources.

I made an assumption in the example that this may ship as version 2.1.0 since new features are being added. Let me know if the example should be changed.

infoblox/resource_infoblox_txt_record.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
infoblox/resource_infoblox_txt_record.go Outdated Show resolved Hide resolved
infoblox/resource_infoblox_txt_record.go Outdated Show resolved Hide resolved
@shadtimm
Copy link
Author

shadtimm commented Nov 19, 2021

TTL issue is resolved with feedback from GO client PR.

I did find one issue in testing, but I suspect it is on the Infoblox API side as I could not find any issues in the provider or go client code.

Here are the repro steps:

  1. Create a TXT record and do not specify a TTL so the grid default is used
  2. Add a TTL to override the grid default
  3. Remove the TTL or set to null which should revert back to the grid default
    a. On the Terraform side the change applies and the state file is updated
    b. Within Infoblox, the previous TTL remains

Changes to the TTL value apply successfully in Terraform and Infoblox. If you match the TTL to the grid default, Infoblox will show it as inheriting from the grid.

Let me know if you need any more information about this.

@vnorguet
Copy link

Hello @shadtimm and @somashekhar, this PR looks stuck since Nov 2021.
I'm interested in this feature, can I help you in some way ?

@shadtimm shadtimm marked this pull request as ready for review October 11, 2022 17:47
@shadtimm
Copy link
Author

Hello @shadtimm and @somashekhar, this PR looks stuck since Nov 2021.
I'm interested in this feature, can I help you in some way ?

@vnorguet This has been pending the approval and integration of the Infoblox Go Client changes. I just saw that the latest go client changes have been merged in, so this can move forward.

@skudriavtsev @ranjishmp Can you please approve the workflow run and continue with the review?

@shadtimm
Copy link
Author

shadtimm commented Dec 8, 2022

@skudriavtsev @ranjishmp @achernevskii Any chance of a PR review?

@JkhatriInfobox
Copy link
Collaborator

TXT record is already supported on latest version [v2.6.0].

Hence closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants