chore: Update go to v1.23.0

[srebhan]

Summary

Checklist

• No AI generated code was used in this PR

Related issues

resolves #15746

[Hipska]

Have min and max now become a reserved word or something? 😂

[srebhan]

@Hipska yes. Those are builtin functions since go v1.21...

[telegraf-tiger]

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

[mskonovalov]

I guess the issue may be related to golangci/golangci-lint#4837 (comment)
or golangci/golangci-lint#4908 (comment)
Although log says

golangci-lint has version v1.60.3 built with go1.23.0

[srebhan]

@mskonovalov the issue is that the CircleCI instance runs out-of-memory unfortunately. In the past we were able to tune the garbage collection params but this doesn't seem to work this time...

[zak-pawel]

It looks like go 1.23.0 and/or golangci-lint 1.60.x need more memory to complete the scan than previous versions, and tweaking GOGC and GOMEMLIMIT wasn't enough this time.

But I found something else. When I started playing around with GODEBUG=gctrace=1, I discovered that golangci-lint uses 36 logical CPUs to perform the scan. However, the Docker / Large setup only has 4 vCPUs:

By default, golangci-lint uses as many CPUs as there are logical CPUs available. It turns out that the system is reporting the number of processors on the host, rather than the number available within the Docker executor.

Confirmation here:

(https://discuss.circleci.com/t/x86-vm-cpu-ram-size-mismatch/45779/6)

And here:

(https://app.circleci.com/pipelines/github/influxdata/telegraf/22537/workflows/43957c5b-61fa-4de1-b1b9-2ca3a29c9581/jobs/350312)

Using only as many CPUs as are actually available to the guest (4 instead of 36) speeds up the jobs (less CPU time spent in garbage collection) and reduces memory usage/makes garbage collection more efficient (with parallel linter threads, using fewer processors allows for a more efficient "stop the world" phase).

[srebhan]

This is really amazing! Thanks for hunting down and fixing the issue @zak-pawel!

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -1.27 % for linux amd64 (new size: 260.7 MB, nightly size 264.0 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz