Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI build #66

Merged
merged 5 commits into from
May 14, 2024
Merged

fix: CI build #66

merged 5 commits into from
May 14, 2024

Conversation

bednar
Copy link
Contributor

@bednar bednar commented May 13, 2024

Proposed Changes

  1. Use lates three version of the swift to test client - 5.8, 5.9, 5.10
  2. Use correct API for expectation
  3. Upgrade Xcode to 15.3.0

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • swift test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.09%. Comparing base (4b7e4b9) to head (7415c0f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #66       +/-   ##
===========================================
+ Coverage   42.31%   65.09%   +22.77%     
===========================================
  Files         145       17      -128     
  Lines       10473     1338     -9135     
===========================================
- Hits         4432      871     -3561     
+ Misses       6041      467     -5574     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar marked this pull request as ready for review May 13, 2024 10:46
@bednar bednar changed the title feat: add swift 5.10 fix: CI build May 13, 2024
@bednar bednar requested a review from karel-rehor May 13, 2024 10:49
@bednar bednar mentioned this pull request May 13, 2024
6 tasks
Copy link

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing in CI. In tests same two basic changes relative to XCTestExpectation and wait(for: [expectation], timeout: 1) are consistent throughout.

@bednar bednar merged commit 2f00fcd into master May 14, 2024
12 checks passed
@bednar bednar deleted the upgrades branch May 14, 2024 11:57
@bednar bednar added this to the 1.7.0 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants