Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dispose window scheduler #641

Merged
merged 4 commits into from
Feb 29, 2024
Merged

fix: dispose window scheduler #641

merged 4 commits into from
Feb 29, 2024

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Feb 2, 2024

Related #640

Proposed Changes

Dispose scheduler when disposing write_api.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (293ed7f) 90.40% compared to head (46ec063) 90.42%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
+ Coverage   90.40%   90.42%   +0.01%     
==========================================
  Files          39       39              
  Lines        3503     3509       +6     
==========================================
+ Hits         3167     3173       +6     
  Misses        336      336              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct.

@bednar bednar merged commit 2661e4d into master Feb 29, 2024
14 checks passed
@bednar bednar deleted the fix-scheduler branch February 29, 2024 08:29
@bednar bednar added this to the 1.41.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants