fix: prevent resetting of domains when no interaction handlers are gi…

…ven (#508)
influxdata · Mar 24, 2021 · 0ec0b5f · 0ec0b5f
1 parent 7e23e2b
commit 0ec0b5f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/giraffe/package.json b/giraffe/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@influxdata/giraffe",
- "version": "2.6.1",
+ "version": "2.6.2",
  "main": "dist/index.js",
  "module": "src/index.js",
  "license": "MIT",

diff --git a/giraffe/src/components/SizedPlot.test.tsx b/giraffe/src/components/SizedPlot.test.tsx
@@ -58,10 +58,7 @@ describe('the SizedPlot', () => {
  />
  )
 
- // when the user (for real) does a single click, then a mouse up happens.
- // chose mouse up because the single click listener wasn't triggering except on
- // double clicks
- fireEvent.mouseUp(screen.getByTestId('giraffe-inner-plot'))
+ fireEvent.doubleClick(screen.getByTestId('giraffe-inner-plot'))
 
  expect(resetSpy).toHaveBeenCalled()
  })
@@ -83,7 +80,7 @@ describe('the SizedPlot', () => {
  />
  )
  // when the user (for real) does a single click, then a mouse up happens.
- // chose mouse up because the single click listener wasn't triggering except on
+ // choose mouse up because the single click listener wasn't triggering except on
  // double clicks
  fireEvent.mouseUp(screen.getByTestId('giraffe-inner-plot'))
 

diff --git a/giraffe/src/components/SizedPlot.tsx b/giraffe/src/components/SizedPlot.tsx
@@ -97,11 +97,12 @@ export const SizedPlot: FunctionComponent<Props> = ({
  },
  }
 
+ const noOp = () => {}
  const singleClick = config.interactionHandlers?.singleClick
  ? () => {
  config.interactionHandlers.singleClick(plotInteraction)
  }
- : memoizedResetDomains
+ : noOp
 
  if (config.interactionHandlers?.hover) {
  config.interactionHandlers.hover(plotInteraction)
@@ -150,6 +151,7 @@ export const SizedPlot: FunctionComponent<Props> = ({
  cursor: `${userConfig.cursor || 'crosshair'}`,
  }}
  onMouseUp={callbacks.singleClick}
+ onDoubleClick={memoizedResetDomains}
  {...hoverTargetProps}
  {...dragTargetProps}
  >