feat(Accordion): Clockface 4 Updates #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChitlangeSahas
force-pushed
the
clockface_4_running_master
branch
from
5117741
to
27afbad
Compare
ChitlangeSahas
commented
Oct 6, 2022
| @@ -106,7 +96,7 @@ export const AccordionRoot = forwardRef<AccordionRef, AccordionProps>( | |||
| const contextState = { | |||
| isExpanded, | |||
| setExpanded, | |||
| iconPlacementPosition: hasBody ? iconPlacementPosition : Direction.None, | |||
| iconPlacementPosition: hasBody ? Direction.Left : Direction.None, | |||
There was a problem hiding this comment.
We want to force left placement of icons for more consistency.
ChitlangeSahas
commented
Oct 6, 2022
| @@ -283,9 +281,6 @@ accordionStories.add( | |||
| style={{justifyContent: 'none', alignItems: 'start', display: 'block'}} | |||
| > | |||
| <Accordion | |||
| iconPlacement={ | |||
There was a problem hiding this comment.
delete that option from storybook
ChitlangeSahas
force-pushed
the
clockface_4_running_master
branch
from
27afbad
to
c9726e3
Compare
ChitlangeSahas
commented
Oct 6, 2022
| @@ -411,9 +400,14 @@ accordionStories.add( | |||
| </Accordion.AccordionHeader> | |||
| <Accordion.AccordionBodyItem> | |||
| <span> | |||
| This is your detailed body. This is your detailed body. This is | |||
There was a problem hiding this comment.
Found this annoying, so changed it.
There was a problem hiding this comment.
Lorem ipsum is a pretty standard replacement.
ChitlangeSahas
force-pushed
the
clockface_4_running_master
branch
from
c9726e3
to
f0f85f9
Compare
1. Colors and Icon placement 2. Fixed the icon bug for when accordion opens/closes (it didn't change icons) 3. Updated storybook
ChitlangeSahas
force-pushed
the
clockface_4_running_master
branch
from
f0f85f9
to
642d8a7
Compare
ChitlangeSahas
commented
Oct 6, 2022
Comment on lines
+77
to
+79
| &--no-body { | ||
| margin-left: 25px; | ||
| } |
There was a problem hiding this comment.
previous, looked off.
ChitlangeSahas
changed the title
ChitlangeSahas
requested review from
a team,
mavarius and
juliajames12
as code owners
|
Part of #6090 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #822
Accordion updates for Clockface 4 to match figma.
Screen.Recording.2022-10-05.at.11.11.18.PM.mov