Error message does not take up space in form #613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #232
Changes
// Describe what you changed
I added new styling container on top of the form error message so that when an error message appears, it does not take up spacing.
Screenshots
Screen.Recording.2021-04-25.at.3.03.53.PM.mov
There is one caveat. This means that developers using clockface have to add in the right spacing after the input element so that this does not happen:
Or I can make it so that it has built in spacing out of the box. @mavarius do you have thoughts on which one might be preferable?
I see good reasons for having pre-defined spacing to prevent the overlap (easy out of the box) and also not having it (more freedom).
// Add screenshots here if relevant
Checklist
Check all that apply