#12 Rails 5.0 incompatibilities Fix #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nimi - Any word on why this hasn't been pushed in almost three years? |
|
@ACPK due to conflicts :P |
haiderRizvii
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause:
Debugging #12 seems when the client-side middleware is chained in server,
Apartment::Tenant.currentis set tobasetenant overriding the correct current_tenant stored initem['apartment'].Chaining client-side in both places is mentioned in Sidekiq docs https://github.com/mperham/sidekiq/wiki/Middleware#sometimes-client-side-middleware-should-be-registered-in-both-places but not sure why it's breaking things now in rails 5.
Fix:
Removing the server chain fixes this for me [rails5, mysql, using schema=true]
P.S
Not sure if this has some other side effects and it will require more testing.