Implement Near Search Operator #62
Conversation
username1103
force-pushed
the
near-search-operator
branch
from
10113be
to
309a92c
Compare
- add Database Annotation Near Example use multi database. So need multi mongo template.
username1103
force-pushed
the
near-search-operator
branch
from
309a92c
to
bf0e622
Compare
username1103
changed the title
| * pivot | ||
| * score = ------------------ | ||
| * pivot + distance |
There was a problem hiding this comment.
It would be better if these lines are wrapped in code block.
| * pivot | |
| * score = ------------------ | |
| * pivot + distance | |
| * | |
| * ``` | |
| * pivot | |
| * score = ------------------ | |
| * pivot + distance | |
| * ``` | |
| * |
| * Origin to query for Number field. | ||
| * This is the origin from which the proximity of the results is measured. | ||
| * | ||
| * For number fields, the value must be of BSON int32, int64, or double data types. |
There was a problem hiding this comment.
There is missing @param docs for origin and pivot method :)
| @Repository | ||
| class NearSearchRepository( | ||
| @Database("sample_mflix") private val mflixMongoTemplate: MongoTemplate, | ||
| @Database("sample_airbnb") private val airbnbMongoTamplate: MongoTemplate, |
There was a problem hiding this comment.
There is some typo. :)
| @Database("sample_airbnb") private val airbnbMongoTamplate: MongoTemplate, | |
| @Database("sample_airbnb") private val airbnbMongoTemplate: MongoTemplate, |
| val score: Double, | ||
| ) | ||
|
|
||
| fun findByRuntime(): AggregationResults<RuntimeDto> { |
There was a problem hiding this comment.
I would be better to add @see docs to each methods :)
| fun findByRuntime(): AggregationResults<RuntimeDto> { | |
| /** | |
| * @see <a href="https://www.mongodb.com/docs/atlas/atlas-search/near/#number-example">Number Example</a> | |
| */ | |
| fun findByRuntime(): AggregationResults<RuntimeDto> { |
| search { | ||
| index = "runtimes" | ||
| near { | ||
| path("runtime") |
There was a problem hiding this comment.
Since we have collection of movie document,
We can use KProperty instead of String.
I think it would be better to guide users to use KProperty instead of strings if possible.
(it applies project stage too)
| path("runtime") | |
| path(Movies::runtime) |
| } | ||
| } | ||
|
|
||
| return mflixMongoTemplate.aggregate(aggregation, "movies", RuntimeDto::class.java) |
There was a problem hiding this comment.
we can use extension function like this :)
| return mflixMongoTemplate.aggregate(aggregation, "movies", RuntimeDto::class.java) | |
| return mflixMongoTemplate.aggregate<Movies, RuntimeDto >(aggregation) |
| val database = repositoryParameter.annotations.find { it is Database } as Database? | ||
| if (database != null) { | ||
| return@associateWith getMongoTemplate(getConnectionString(database.value)) | ||
| } |
There was a problem hiding this comment.
To remove warning from return@associateWith.
we can use let scope function.
| val database = repositoryParameter.annotations.find { it is Database } as Database? | |
| if (database != null) { | |
| return@associateWith getMongoTemplate(getConnectionString(database.value)) | |
| } | |
| repositoryParameter.findAnnotation<Database>()?.let { | |
| getMongoTemplate(getConnectionString(it.value)) | |
| } ?: mongoTemplate |
| val connectionString = "mongodb+srv://$ATLAS_DOMAIN/${atlasTest.database}?retryWrites=true&w=majority" | ||
| val mongoTemplate = MongoTemplate(SimpleMongoClientDatabaseFactory(connectionString)) | ||
| val connectionString = getConnectionString(atlasTest.database) | ||
| val mongoTemplate = getMongoTemplate(connectionString) | ||
|
|
||
| val parameters = testConstructor.parameters.associateWith { parameter -> | ||
| val parameterClass = parameter.type.classifier as KClass<*> |
There was a problem hiding this comment.
If you don mind, Could you change 25, 43 lines to use findAnnotation extension function?
val atlasTest = clazz.findAnnotation<AtlasTest>() ?: return null
checkNotNull(parameterClass.findAnnotation<Repository>()) {
I think your idea is great 👍
We can certainly add the validation you mentioned, but currently, we are not add value validation in the project.
You are right. there are some operators that |
|
@jbl428 Thanks, I've corrected the things you mentioned. |
resolve #13
Show
Database annotations
The Near Operator example uses two databases in mongodb documetation. Therefore, it is necessary to inject two MongoTemplates, so I implemented it by adding the annotation Database. Please give your opinion on this.
pivot verification
Additionally, the document specifies that Near's pivot must be greater than 0. I'm wondering whether to add this as validation. What do you think?
Path type settings
Origin can include Number, ISODate, and GeoJsonPoint. So path has to be name of Number, ISODate, GeoJsonPoint fields. I attempted to override methods for each type, but encountered problem due to generics not being recognized differently. So an annotation called JvmName was added.