Refactoring QueryStringSearchOperatorDsl #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbl428
reviewed
Oct 1, 2023
Comment on lines
46
to
48
| query = Query("\"$escaped\"", field) | ||
|
|
||
| return query |
There was a problem hiding this comment.
I think this idea is great.
but there is another solution.
we can change QueryStringSearchOperatorDsl.kt like this.
fun query(configuration: QueryStringQueryOptionDsl.() -> QueryStringQueryOptionDsl.Query) {
val query = QueryStringQueryOptionDsl().configuration()
document["query"] = query.toString()
}We no longer need to reassign the query in every function by using this method.
what do you think?
There was a problem hiding this comment.
Thanks for the suggestion.
I'm going to ask you again just to make sure I understand what you mean.
If I write it as you say,
the queryproperty that existed in the QueryStringQueryOptionDslclass will disappear?
There was a problem hiding this comment.
Yes, and build method also removed.
jbl428
reviewed
Oct 1, 2023
| * @param rightInclusion The right value is included in the range | ||
| * @param field Indexed field to search | ||
| */ | ||
| fun range(left: String, right: String, leftInclusion: Boolean = true, rightInclusion: Boolean = true, field: KProperty<String?>): Query { |
- add Database Annotation Near Example use multi database. So need multi mongo template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Jake Son.
I've made a few edits to the work I've done.
Please check and approve.