implement wildcard search operator dsl #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masonJS
changed the title
masonJS
force-pushed
the
feat/wildcard-search-operator-dsl
branch
from
d2c70ff
to
54bba39
Compare
inflab-int
reviewed
Sep 29, 2023
Comment on lines
26
to
27
| } | ||
| project { |
There was a problem hiding this comment.
please add this this between stage.
I will add $limit stage after it is implemented.
// TODO: add $limit stage
There was a problem hiding this comment.
I have found that this example does not have $limit
my mistake :)
inflab-int
reviewed
Sep 29, 2023
Comment on lines
46
to
47
| } | ||
| project { |
There was a problem hiding this comment.
also required // TODO: add $limit stage
jbl428
reviewed
Sep 29, 2023
| val result = wildcardSearchRepository.findTitleWithQuestionMark() | ||
|
|
||
| // then | ||
| result.mappedResults.map { it.title shouldContain "?" } |
There was a problem hiding this comment.
Until $limit is implemented, we should take 5 element explicitly.
result.mappedResults.take(5).map { it.title } shouldBe listof(
"...."
"...."
)
masonJS
force-pushed
the
feat/wildcard-search-operator-dsl
branch
from
54bba39
to
0e0f74a
Compare
jbl428
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #20