Skip to content

Commit

Permalink
Drop support for Ruby 2.6 and 2.7 and Rails 5.2 and 6.0
Browse files Browse the repository at this point in the history
  • Loading branch information
lovro-bikic committed Sep 6, 2024
1 parent db75534 commit c566656
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 29 deletions.
21 changes: 4 additions & 17 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,23 +27,10 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2', '3.3']
ruby: ['3.0', '3.1', '3.2', '3.3']
money: ['6.14.0', '6.14.1', '6.16.0', '6.17.0', '6.18.0', '6.19.0']
money_rails: ['1.15.0']
rails: ['~> 5.2.0', '~> 6.0.0', '~> 6.1.0', '~> 7.0.0', '~> 7.1.0']
exclude:
- ruby: '2.6'
rails: '~> 7.0.0'
- ruby: '2.6'
rails: '~> 7.1.0'
- ruby: '3.0'
rails: '~> 5.2.0'
- ruby: '3.1'
rails: '~> 5.2.0'
- ruby: '3.2'
rails: '~> 5.2.0'
- ruby: '3.3'
rails: '~> 5.2.0'
rails: ['~> 6.1.0', '~> 7.0.0', '~> 7.1.0']
steps:
- uses: actions/checkout@v4
- name: Set up Ruby
Expand All @@ -62,7 +49,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2', '3.3']
ruby: ['3.0', '3.1', '3.2', '3.3']
money: ['6.14.0', '6.14.1', '6.16.0', '6.17.0', '6.18.0', '6.19.0']
steps:
- uses: actions/checkout@v4
Expand All @@ -82,7 +69,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2', '3.3']
ruby: ['3.0', '3.1', '3.2', '3.3']
money_rails: ['1.15.0']
mongodb: ['4.4']
steps:
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
AllCops:
TargetRubyVersion: 2.6
TargetRubyVersion: 3.0
NewCops: enable
Exclude:
- 'spec_money/**/*'
Expand Down
13 changes: 3 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -332,23 +332,16 @@ Money.default_date_column = nil
## Supported Versions

`money_with_date` has the following version requirements:
- Ruby: **>= 2.6.0**
- Ruby: **>= 3.0.0**
- money: **>= 6.14.0** and **<= 6.19.0**
- money-rails: **1.15.0**

The gem has been tested against all possible combinations of supported Ruby, Rails, money, and money-rails versions:
- Ruby: `2.6`, `2.7`, `3.0`, `3.1`, `3.2` and `3.3`
- Rails: `~> 5.2.0`, `~> 6.0.0`, `~> 6.1.0`, `~> 7.0.0` and `~> 7.1.0`
- Ruby: `3.0`, `3.1`, `3.2` and `3.3`
- Rails: `~> 6.1.0`, `~> 7.0.0` and `~> 7.1.0`
- money: `6.14.0`, `6.14.1`, `6.16.0`, `6.17.0`, `6.18.0` and `6.19.0`
- money-rails: `1.15.0`

The following combinations have been excluded from the test matrix because of incompatibility:
- Ruby `2.6` with Rails `~> 7.0.0` and `~> 7.1.0`
- Ruby `3.0` with Rails `~> 5.2.0`
- Ruby `3.1` with Rails `~> 5.2.0`
- Ruby `3.2` with Rails `~> 5.2.0`
- Ruby `3.3` with Rails `~> 5.2.0`

In addition to running its own test suite, the CI for this gem also runs [money's](https://github.com/RubyMoney/money/tree/main/spec) and [money-rails's](https://github.com/RubyMoney/money-rails/tree/main/spec) test suites with this gem loaded, to prevent regressions. This has been achieved by cloning their test suites from GitHub and requiring this gem in their spec files. For technical information, check the CI [workflow](.github/workflows/ci.yml).

## Compatibility
Expand Down
2 changes: 1 addition & 1 deletion money_with_date.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
spec.summary = "Extension for the money gem which adds dates to Money objects"
spec.homepage = "https://github.com/infinum/money_with_date"
spec.license = "MIT"
spec.required_ruby_version = ">= 2.6.0"
spec.required_ruby_version = ">= 3.0.0"

spec.metadata["homepage_uri"] = spec.homepage
spec.metadata["source_code_uri"] = spec.homepage
Expand Down

0 comments on commit c566656

Please sign in to comment.