Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Preferences screen #1365

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat: Preferences screen #1365

wants to merge 3 commits into from

Conversation

joshuayoes
Copy link
Contributor

@joshuayoes joshuayoes commented Dec 15, 2023 •
edited
Loading

This PR address this issue #1354 by adding a new preferences screen that shows the electron store.

TODO:

  • Update "Settings" to navigate to new "Preferences" tab
Screenshot 2023-12-15 at 10 31 05 AM
  • Add keyboard shortcut Cmd + , to navigate to "Preferences" tab
Screenshot 2023-12-15 at 10 31 46 AM
  • Add styles to "Preferences" and allow for editing config values

@gustavoabel
Copy link

@joshuayoes Do we already have anything about customizing shortcuts?

@joshuayoes
Copy link
Contributor Author

@gustavoabel not currently, we have an open issue about this: #1281

A contribution for this would be very welcome, we have some docs for this: https://docs.infinite.red/reactotron/contributing/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryanlntn ryanlntn

@robinheinze robinheinze

@joshuayoes joshuayoes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshuayoes @gustavoabel @ryanlntn @robinheinze