Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Zustand Recipe to include removal of useEffect dependecy #181

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

ecroce
Copy link
Contributor

@ecroce ecroce commented Nov 14, 2024

Submitting a fix for #166 where removal of the episodeStore dependency in the useEffect was missed in the recipe.
Also updates the existing boilerplate code snippets to reflect the current ignite code.

Open Source License Notice for Contributors

If you are contributing a recipe to this repository, you agree to license your contribution under the terms of the CC BY-SA 4.0 license.

If you have any questions, please reference the CONTRIBUTING.md or LICENSE.md file for more information.

Thank you for your contribution!

Copy link
Contributor

@frankcalise frankcalise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!!

🎉

@frankcalise frankcalise linked an issue Nov 14, 2024 that may be closed by this pull request
@ecroce ecroce force-pushed the zustand-fix-missing-code-change branch from 54bb9e6 to 5edf33e Compare November 15, 2024 16:15
@ecroce
Copy link
Contributor Author

ecroce commented Nov 15, 2024

Same commit, just verified now as I had to update the signature to reflect my non-client email.

@ecroce ecroce merged commit f6bcc74 into main Nov 15, 2024
1 check passed
@ecroce ecroce deleted the zustand-fix-missing-code-change branch November 15, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing UseEffect Info on Zustand Recipe
2 participants