Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recipes): react-native-vision-camera #105

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

frankcalise
Copy link
Contributor

Description

  • Closes react-native-vision-camera #104
  • Implements a barcode scanner with Ignite v9 and react-native-vision-camera
  • Requests permissions for camera
  • Able to scan barcodes with camera interface
  • Adds a store and screen to view previously scanned codes via Ignite generators

@frankcalise frankcalise self-assigned this Oct 23, 2023
@frankcalise
Copy link
Contributor Author

I need to mention the expo run commands to use here

@var-che
Copy link

var-che commented Oct 28, 2023

The comments in those tsx files are made with //, which is incorrect and will produce errors on user. It will warn the user to wrap some strings around with Text tag, very generic. It was kinda hard to see what the problem, because those comment tags are common with the JS devs, and many will miss it.

TLDR: // comment thing needs to be removed.

@frankcalise
Copy link
Contributor Author

@var-che those comments are particular to docusaurus formatting and not meant to be exactly copied from the raw markdown here, so no changes need to be made for the PR but yeah fine to remove them to give it a try

@var-che
Copy link

var-che commented Oct 28, 2023

Right on! Thanks for the clarification @frankcalise !

@frankcalise frankcalise merged commit 85ad7b2 into main Nov 28, 2023
1 check passed
@frankcalise frankcalise deleted the feat/react-native-vision-camera branch November 28, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-native-vision-camera
3 participants