Tasks

[dpanshug]

Closes #516

Execute a task: https://issues.redhat.com/browse/ISPN-14305
Create a task: https://issues.redhat.com/browse/ISPN-12091
Update a task: https://issues.redhat.com/browse/ISPN-14304

[karesti]

I need the build working here

[karesti]

The empty message is not ok

Tooltip message seems incomplete

Counter name is required

[karesti]

package.json lock should not be changed

[karesti]

which script have you used to test the upload?
would be good for some testing @dpanshug

[domiborges]

I have the docs locally. I'll push it tomorrow. The only thing I'm missing is the tooltip. I'm not sure what to put there.

[karesti]

@dpanshug needs rebase

[domiborges]

I need some hint what to put in the tooltip. https://infinispan.org/docs/stable/titles/server/server.html#remote-execution I see the tasks can be scripts or custom Java classes. Is it necessary to stop the server? etc.

[dpanshug]

@dvagnero need to merge your commit with mine for some changes

[karesti]

@dpanshug let me know when this is ready again plz

[dpanshug]

which script have you used to test the upload? would be good for some testing @dpanshug

Writing a E2E test for this.

[dpanshug]

I need some hint what to put in the tooltip. https://infinispan.org/docs/stable/titles/server/server.html#remote-execution I see the tasks can be scripts or custom Java classes. Is it necessary to stop the server? etc.

@tristantarrant can you help here pls.

[dpanshug]

@andyuk1986 Added a cypress test, pls review :)

[andyuk1986]

Cypress test looks good but scenario for task edit/save is not there.

[dpanshug]

@dvagnero Found this in documentation

You can implement tasks as custom Java classes or define scripts in languages such as JavaScript.`

Maybe this info is useful for the tooltip.

[domiborges]

@dvagnero Found this in documentation

You can implement tasks as custom Java classes or define scripts in languages such as JavaScript.`

Maybe this info is useful for the tooltip.

Okay so it can be Java or Javascript. What about requirements? Having a script engine? Anything else?

[dpanshug]

Okay so it can be Java or Javascript. What about requirements? Having a script engine? Anything else?

For the JS task, you will need to install a JS script engine on the server, it won't work with JDK 17.

[domiborges]

Thank you for suggestions @dpanshug
Is it necessary to stop the server before adding a task?

[tristantarrant]

Thank you for suggestions @dpanshug Is it necessary to stop the server before adding a task?

If it's a Java task, yes. Script tasks can be added at runtime

[andyuk1986]

@dvagnero just to add my two cents - as @tristantarrant said, there are 2 types of tasks: remote server tasks and Script Tasks. Console shows both Remote and Script Tasks. But at the moment (with this PR) it is possible to create/edit/execute only Script Tasks, and - no, for these tasks no Server restart is needed.
For Remote tasks the process is different -> jar file should be copied to server's data folder and server need to be restarted but I don't know if these use case will be covered with Console in the future.

[karesti]

• When the task creation gives an error, the error should be displayed in the top of the popup and not in the alert. Otherwise we lose what we wrote in the editor.
  First validate that the task was created, and if it's ok, close the popup and display an alert of ok.
• The task list should display the task that has been created

If the user can't see the task, we should not be displaying any alert but only listing the names of the tasks and disable the actions the user can't do.

[domiborges]

Thanks @andyuk1986 for the explanation. I was under the impression that we're aiming for both tasks and scripts.
So @dpanshug and @karesti do you plan to add support for tasks written in Java? And if yes, would users use the same process to upload either a script or task?
Tasks and scripts have some similarities but also a different workflow and prerequisites (script engine, stopping server etc). What do you think about having a radio button to choose the Task type inside the Create a task dialogue? Or some other way to differentiate between these two?

[tristantarrant]

There is no way to upload a Java task: it needs to be deployed before startup

[dpanshug]

The task list should display the task that has been created

@karesti I've tried fixing it, list gets updated when there already exist some tasks. But if you try to create the task for the first time, the API seems to not fetch the tasks list without refreshing separately. Can you please help me out here. :)

[domiborges]

Hi @dpanshug I changed the tooltip. Let me know if you need anything or if you make any changes that require docs :)

[karesti]

@dpanshug check how the entries add works plz

[dpanshug]

@karesti Pls check if this can be merged :)

[karesti]

@dpanshug no, this feature can't be merged as it is. if the javascript engine is not available, we should disable the task creation. it is confusing and useless. for that we need an endpoint in the scripts that indicates that an js engine is available.
I'm unable to test and understand he feature (as a user from the console).