Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of chinese analyzer #404

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

yingfeng
Copy link
Member

@yingfeng yingfeng commented Jan 2, 2024

What problem does this PR solve?

Remove the extra string copy between jieba and analyzer interfaces

Issue link: #367

What is changed and how it works?

Code changes

  • Has Code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@yingfeng yingfeng added the ci PR can be test label Jan 2, 2024
@yingfeng yingfeng merged commit 6a5487c into infiniflow:main Jan 2, 2024
3 of 4 checks passed
@yingfeng yingfeng changed the title Imporove performance of chinese analyzer Improve performance of chinese analyzer Jan 2, 2024
yingfeng added a commit to yingfeng/infinity that referenced this pull request Jan 2, 2024
Remove the extra string copy between jieba and analyzer interfaces
yingfeng added a commit that referenced this pull request Jan 2, 2024
Remove the extra string copy between jieba and analyzer interfaces
JinHai-CN pushed a commit that referenced this pull request Jan 3, 2024
Remove the extra string copy between jieba and analyzer interfaces
JinHai-CN pushed a commit that referenced this pull request Jan 3, 2024
Remove the extra string copy between jieba and analyzer interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci PR can be test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant