Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lock when set fragment task status. #401

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Add lock when set fragment task status. #401

merged 4 commits into from
Jan 2, 2024

Conversation

small-turtle-1
Copy link
Contributor

@small-turtle-1 small-turtle-1 commented Dec 29, 2023 •
edited
Loading

What problem does this PR solve?

Add corresponding issue link with summary if exists -->

Issue link:

What is changed and how it works?

Code changes

  • Has Code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@small-turtle-1 small-turtle-1 force-pushed the fix_bugf branch 2 times, most recently from f8d30c4 to 2069599 Compare December 29, 2023 13:57
@small-turtle-1 small-turtle-1 changed the title Add lock when set status. Add lock when set fragment task status. Dec 29, 2023
@small-turtle-1 small-turtle-1 changed the title Add lock when set fragment task status. Add lock when set fragment task status. 1 Dec 29, 2023
@small-turtle-1 small-turtle-1 changed the title Add lock when set fragment task status. 1 Add lock when set fragment task status. 2 Dec 29, 2023
@small-turtle-1 small-turtle-1 changed the title Add lock when set fragment task status. 2 Add lock when set fragment task status. 3 Dec 29, 2023
@small-turtle-1 small-turtle-1 changed the title Add lock when set fragment task status. 3 Add lock when set fragment task status. Dec 30, 2023
@yuzhichang
Copy link
Member

@mergify refresh

@mergify Mergify
Copy link

mergify bot commented Dec 30, 2023

refresh

✅ Pull request refreshed

@yuzhichang
Copy link
Member

@mergify rebase

@mergify Mergify
Copy link

mergify bot commented Dec 30, 2023

rebase

✅ Branch has been successfully rebased

@yuzhichang yuzhichang added the ci PR can be test label Jan 2, 2024
@JinHai-CN
Copy link
Contributor

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jan 2, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 0d19979

@mergify mergify bot merged commit 0d19979 into infiniflow:main Jan 2, 2024
4 checks passed
@small-turtle-1 small-turtle-1 deleted the fix_bugf branch January 2, 2024 02:39
small-turtle-1 added a commit to small-turtle-1/infinity that referenced this pull request Jan 3, 2024
@small-turtle-1
Add lock when set fragment task status. (infiniflow#401)
206f844 
* Add lock when set status.

* Add lock.

* Fix logic bug.

* Fix the bug. Add log.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinHai-CN JinHai-CN JinHai-CN approved these changes

Assignees
No one assigned
Labels
ci PR can be test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@small-turtle-1 @yuzhichang @JinHai-CN