fix: remapper error when Project has no first column or column order … #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JinHai-CN
approved these changes
Dec 29, 2023
KKould
added a commit
to KKould/infinity-k
that referenced
this pull request
Jan 4, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
* implement physical_limit.cpp for support limit (#391) * feat: impl limit * test: add limit.slt for limit case * fix conflict * perf: Implement MergeLimit to end the upstream operator early * code fmt * fix: the limit quantity is incorrect. When executing `SELECT * FROM test_big_limit limit 8500 offset 20;` when 9000 pieces of data are executed * code fmt * fix: remapper error when Project has no first column or column order is reverse order (#398) * fix: column binding miss on order by functions * fix & perf: - fix physical_limit offset - fix lazy load output_names wrong on join - remove `RetainColumnByIds` * fix: order by function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix:
e.g.
SELECT c3, c2, c1 from select3;SELECT c2, c3 from select3;Code changes
Check List
Tests
Side effects
Note for reviewer