Add scheduler #395
Merged
Add scheduler #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
small-turtle-1
force-pushed
the
add_scheduler
branch
from
1e3f635 to
d896ede
Compare
JinHai-CN
approved these changes
Dec 29, 2023
small-turtle-1
force-pushed
the
add_scheduler
branch
from
d864ea3 to
6c3a764
Compare
small-turtle-1
added a commit
to small-turtle-1/infinity
that referenced
this pull request
Jan 3, 2024
* tmp schedule strategy. * Add scheduler when fragment task finished. * Prevent stream operator dead loop. * Fix bug of not finishing. * Replace create index source and sink operator. * Fix bug that source operator of stream fragment is not kQueue. * Fmt. * Fix: check if task is already in worker loop in TaskScheduler::ScheduleFragment. * Feat: add simple cpu affinity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Refactor the scheduler.
Issue link:
#387
What is changed and how it works?
TaskScheduler::Schedule. Init fragments are leaf fragments.TaskScheduler::WorkerLoop, when a fragment task finished, ifFragmentTask::IsCompletereturn true,FragmentTask::CompleteTaskis called, which callsFragmentContext::TryFinishFragment. The latter reduce theunfinished_task_n_inFragmentContextand when it is 0, it reduce its parentFragmentContext'sunfinished_child_n_byFragmentContext::TryStartFragment. If it returns true, then schedule that parent fragment byTaskScheduler::ScheduleFragment.FragmentType::kParallelStream, the return value ofFragmentContext::TryStartFragmentwill be ignored, and all its parent tasks that not in work loop can be scheduled in.FragmentType::kParallelStream, ifFragmentContext::TryFinishFragmentreturn false, the task souce will be checked if there is more data. If not, this task will be scheduled out.Code changes
Check List
Tests
Side effects
Note for reviewer