Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug #363

Merged
merged 3 commits into from
Dec 25, 2023
Merged

Fix bug #363

merged 3 commits into from
Dec 25, 2023

Conversation

small-turtle-1
Copy link
Contributor

What problem does this PR solve?

Fix unit test fail

What is changed and how it works?

  1. Fix bufferobj unit test dead lock bug. Do not use bufferobj.Save() without following bufferobj.CloseFile()
  2. Fix bufferobj move file dead lock bug. bufferobj.Save() return false if call move file.

Code changes

  • Has Code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@yuzhichang yuzhichang merged commit 59b0c6e into infiniflow:main Dec 25, 2023
1 check passed
@small-turtle-1 small-turtle-1 deleted the fix_bug branch December 25, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@small-turtle-1 @yuzhichang