Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize physical_sort.cpp implementation #354

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

KKould
Copy link
Member

@KKould KKould commented Dec 22, 2023

What problem does this PR solve?

perf:

  • Evaluate OrderBy expression ahead of time for sorting
  • Use divide-and-conquer merge to replace the original merge algorithm

bench:

  • add benchmark for sort

Code changes

  • Has Code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@yuzhichang yuzhichang merged commit c796736 into infiniflow:main Dec 22, 2023
1 check passed
yuzhichang added a commit that referenced this pull request Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants