Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci bug. #352

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Fix ci bug. #352

merged 2 commits into from
Dec 22, 2023

Conversation

small-turtle-1
Copy link
Contributor

What problem does this PR solve?

CI test fail.

What is changed and how it works?

  1. Add thread id in spd log.
  2. Fix thread race in BufferObj::CloseFile and BufferObj::Free

Code changes

  • Has Code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@small-turtle-1 small-turtle-1 changed the title Fix ci bug. [WIP] Fix ci bug. Dec 22, 2023
2. Fix thread race in BufferObj::CloseFile and BufferObj::Free
@JinHai-CN JinHai-CN merged commit f6da3ff into infiniflow:main Dec 22, 2023
1 check failed
@JinHai-CN JinHai-CN changed the title [WIP] Fix ci bug. Fix ci bug. Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants