Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
CI test may crash when run insert_big_embedding test.
What is changed and how it works?
Possible situation: the file descriptor is closed when another thread write the bufferobj to spill directory.
But such situation violate the buffer_obj status. When a thread call BufferObj::Close(), it must has called BufferObj::Save(), which holds the lock and sets the buffer_obj.type_ to kPersistent. Then when bufferobj writes to spill directory, it must be called by BufferObj::Free(), which also holds the lock.
What's more, the log shows BufferObj::Save() is never called
And add extra log for CI debug.
Code changes
Check List
Tests
Side effects
Note for reviewer