Fix shutdown bug.

infiniflow · Dec 13, 2024 · 0040f1c · 0040f1c
1 parent 76d4bde
commit 0040f1c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/python/restart_test/infinity_runner.py b/python/restart_test/infinity_runner.py
@@ -137,6 +137,7 @@ def infinity_runner_decorator_factory(
     shutdown_out: bool = False,
     kill: bool = False,
     terminate_timeout: int = 60,
+    check_kill: bool = True
 ):
     def decorator(f):
         def wrapper(*args, **kwargs):
@@ -150,7 +151,11 @@ def wrapper(*args, **kwargs):
                 except Exception:
                     if not shutdown_out:
                         raise
-                infinity_runner.uninit(kill, terminate_timeout)
+                try:
+                    infinity_runner.uninit(kill, terminate_timeout)
+                except Exception:
+                    if check_kill:
+                        raise
 
         return wrapper
 

diff --git a/src/storage/storage.cpp b/src/storage/storage.cpp
@@ -294,6 +294,7 @@ Status Storage::AdminToWriter() {
         UnrecoverableError("Memory index tracer was initialized before.");
     }
     memory_index_tracer_ = MakeUnique<BGMemIndexTracer>(config_ptr_->MemIndexMemoryQuota(), new_catalog_.get(), txn_mgr_.get());
+    cleanup_info_tracer_ = MakeUnique<CleanupInfoTracer>();
 
     bg_processor_->Start();
 
@@ -634,7 +635,6 @@ Status Storage::SetStorageMode(StorageMode target_mode) {
         LOG_WARN(fmt::format("Set unchanged mode"));
         return Status::OK();
     }
-    cleanup_info_tracer_ = MakeUnique<CleanupInfoTracer>();
     switch (current_mode) {
         case StorageMode::kUnInitialized: {
             if (target_mode != StorageMode::kAdmin) {
@@ -732,6 +732,7 @@ Status Storage::AdminToReaderBottom(TxnTimeStamp system_start_ts) {
         UnrecoverableError("Memory index tracer was initialized before.");
     }
     memory_index_tracer_ = MakeUnique<BGMemIndexTracer>(config_ptr_->MemIndexMemoryQuota(), new_catalog_.get(), txn_mgr_.get());
+    cleanup_info_tracer_ = MakeUnique<CleanupInfoTracer>();
 
     new_catalog_->StartMemoryIndexCommit();
     new_catalog_->MemIndexRecover(buffer_mgr_.get(), system_start_ts);