Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ppp #3

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Ppp #3

merged 1 commit into from
Dec 30, 2023

Conversation

yuzhichang
Copy link
Member

No description provided.

@yuzhichang yuzhichang added the ci Can be test label Dec 30, 2023
@yuzhichang
Copy link
Member Author

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Dec 30, 2023 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d4fca1a

@mergify mergify bot merged commit d4fca1a into infiniflow:main Dec 30, 2023
4 checks passed
yuzhichang pushed a commit that referenced this pull request Jun 21, 2024
@JinHai-CN
Fix sparse expression parsing memory leak (#1338)
e9a484b 
### What problem does this PR solve?

```
=================================================================
==58327==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 576 byte(s) in 24 object(s) allocated from:
    #0 0x55be02292f41 in operator new(unsigned long) (/infinity/cmake-build-debug/src/infinity+0x707f41) (BuildId: a8a47e2552e9916f1f7d2b289e095233935d70f4)
    #1 0x55be051ac8d0 in sqlparse(void*, infinity::ParserResult*) /infinity/cmake-build-debug/parser.y:2942:39
    #2 0x55be050f73b8 in infinity::SQLParser::Parse(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, infinity::ParserResult*) /infinity/src/parser/sql_parser.cpp:39:9
    #3 0x55be02a13141 in infinity::QueryContext@query_context::Query(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&) /infinity/src/main/query_context.cpp:90:14
    #4 0x55be02454cbb in infinity::Connection@connection::HandlerSimpleQuery(infinity::QueryContext@query_context*) /infinity/src/network/connection.cpp:155:41
    #5 0x55be024541b3 in infinity::Connection@connection::HandleRequest() /infinity/src/network/connection.cpp:131:13
    #6 0x55be0245219b in infinity::Connection@connection::Run() /infinity/src/network/connection.cpp:70:13
    #7 0x55be0284b0ac in infinity::PGServer@pg_server::StartConnection(std::shared_ptr<infinity::Connection@connection>&)::$_0::operator()() /infinity/src/network/pg_server.cpp:81:25
    #8 0x55be0284b004 in void std::__invoke_impl<void, infinity::PGServer@pg_server::StartConnection(std::shared_ptr<infinity::Connection@connection>&)::$_0>(std::__invoke_other, infinity::PGServer@pg_server::StartConnection(std::shared_ptr<infinity::Connection@connection>&)::$_0&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:61:14
    #9 0x55be0284afc4 in std::__invoke_result<infinity::PGServer@pg_server::StartConnection(std::shared_ptr<infinity::Connection@connection>&)::$_0>::type std::__invoke<infinity::PGServer@pg_server::StartConnection(std::shared_ptr<infinity::Connection@connection>&)::$_0>(infinity::PGServer@pg_server::StartConnection(std::shared_ptr<infinity::Connection@connection>&)::$_0&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:96:14
    #10 0x55be0284af9c in void std::thread::_Invoker<std::tuple<infinity::PGServer@pg_server::StartConnection(std::shared_ptr<infinity::Connection@connection>&)::$_0>>::_M_invoke<0ul>(std::_Index_tuple<0ul>) /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_thread.h:292:13
    #11 0x55be0284af74 in std::thread::_Invoker<std::tuple<infinity::PGServer@pg_server::StartConnection(std::shared_ptr<infinity::Connection@connection>&)::$_0>>::operator()() /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_thread.h:299:11
    #12 0x55be0284ade8 in std::thread::_State_impl<std::thread::_Invoker<std::tuple<infinity::PGServer@pg_server::StartConnection(std::shared_ptr<infinity::Connection@connection>&)::$_0>>>::_M_run() /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_thread.h:244:13
    #13 0x55be05869602 in execute_native_thread_routine thread.o
```

### Type of change

- [x] Bug Fix (non-breaking change which fixes an issue)

Signed-off-by: Jin Hai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci Can be test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yuzhichang