Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use Json schema for model calls #308

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

johnjcsmith
Copy link
Contributor

@johnjcsmith johnjcsmith commented Dec 15, 2024

As part of removing Zod usage for schemas, remove structured result parsing from model.structured and instead accept a Json schema object.

This does mean we can't return a typed result from model.structured() so Zod parsing is done outside of this function where applicable.

@johnjcsmith johnjcsmith marked this pull request as ready for review December 15, 2024 04:19
@johnjcsmith johnjcsmith force-pushed the feat/remove-deserialize-fn-schema branch from 458d0d7 to 2b0104e Compare December 15, 2024 04:22
Copy link
Contributor

@nadeesha nadeesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@johnjcsmith johnjcsmith merged commit da55519 into main Dec 15, 2024
27 checks passed
@johnjcsmith johnjcsmith deleted the feat/remove-deserialize-fn-schema branch December 15, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants