fix: Streamline run timeline fetching and rendering (#564)

* refactor: streamline run timeline fetching and rendering * fix: Minor changes 2025-01-13-12:21:32 * fix: Minor changes 2025-01-13-15:54:42 * fix: Minor changes 2025-01-13-15:54:42 * fix: Minor changes 2025-01-13-15:54:42 * fix: Minor changes 2025-01-14-12:11:19
inferablehq · Jan 14, 2025 · 4f301fb · 4f301fb
1 parent 8cfa65f
commit 4f301fb
Show file tree

Hide file tree

Showing 7 changed files with 258 additions and 273 deletions.
diff --git a/app/app/clusters/[clusterId]/runs/[runId]/page.tsx b/app/app/clusters/[clusterId]/runs/[runId]/page.tsx
@@ -1,5 +1,3 @@
-"use client";
-
 import { Run } from "@/components/workflow";
 
 function Page({

diff --git a/app/app/clusters/[clusterId]/settings/details/page.tsx b/app/app/clusters/[clusterId]/settings/details/page.tsx
@@ -30,7 +30,6 @@ const formSchema = z.object({
   description: z.string().default(""),
   debug: z.boolean().default(false),
   enableCustomAuth: z.boolean().default(false),
-  enableKnowledgebase: z.boolean().default(false),
   handleCustomAuthFunction: z.string().default(""),
 });
 
@@ -55,7 +54,6 @@ export default function DetailsPage({ params: { clusterId } }: { params: { clust
         form.setValue("description", details.body.description ?? "");
         form.setValue("debug", details.body.debug ?? false);
         form.setValue("enableCustomAuth", details.body.enableCustomAuth ?? false);
-        form.setValue("enableKnowledgebase", details.body.enableKnowledgebase ?? false);
         form.setValue("handleCustomAuthFunction", details.body.handleCustomAuthFunction ?? "");
       } else {
         createErrorToast(details, "Failed to fetch cluster details");
@@ -78,7 +76,6 @@ export default function DetailsPage({ params: { clusterId } }: { params: { clust
             description: data.description,
             debug: data.debug,
             enableCustomAuth: data.enableCustomAuth,
-            enableKnowledgebase: data.enableKnowledgebase,
             handleCustomAuthFunction: data.handleCustomAuthFunction,
           },
         });

diff --git a/app/client/client.ts b/app/client/client.ts
@@ -15,3 +15,11 @@ export const client = initClient(contract, {
   baseUrl: getBaseUrl(),
   baseHeaders: {},
 });
+
+export const clientWithAbortController = (signal: AbortSignal) => {
+  return initClient(contract, {
+    baseUrl: getBaseUrl(),
+    baseHeaders: {},
+    abortSignal: signal,
+  });
+};
diff --git a/app/client/contract.ts b/app/client/contract.ts
@@ -536,8 +536,6 @@ export const definition = {
         debug: z.boolean(),
         enableCustomAuth: z.boolean(),
         handleCustomAuthFunction: z.string().nullable(),
-        enableKnowledgebase: z.boolean(),
-        lastPingAt: z.date().nullable(),
         isDemo: z.boolean(),
         machines: z.array(
           z.object({

diff --git a/app/components/breadcrumbs.tsx b/app/components/breadcrumbs.tsx
@@ -55,11 +55,6 @@ export async function ClusterBreadcrumbs({ clusterId }: ClusterBreadcrumbsProps)
       <Link href={`/clusters/${clusterId}/agents`} className={linkStyles}>
         <Bot className="h-4 w-4" /> Agents
       </Link>
-      {clusterDetails.body.enableKnowledgebase && (
-        <Link href={`/clusters/${clusterId}/knowledge`} className={linkStyles}>
-          <BookOpen className="h-4 w-4" /> Knowledge
-        </Link>
-      )}
       <Link href={`/clusters/${clusterId}/integrations`} className={linkStyles}>
         <NetworkIcon className="h-4 w-4" /> Integrations
       </Link>

diff --git a/app/components/chat/function-call.tsx b/app/components/chat/function-call.tsx
@@ -114,7 +114,7 @@ function FunctionCall({
         <div className="rounded-lg border border-border/50 bg-background/50 p-4">
           <div className="space-y-2">
             <div className="flex flex-row items-center space-x-2">
-              <SheetTrigger>
+              <SheetTrigger asChild>
                 <Button
                   size="sm"
                   className={`${approvalRequested && !approved ? "opacity-50" : ""}