Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snmp polling attributes #878

Closed
wants to merge 8 commits into from
Closed

snmp polling attributes #878

wants to merge 8 commits into from

Conversation

nickhilliard
Copy link
Member

[BF] mismatch between snmp polling attributes and db column names

$SwitchPort::SNMP_MAP and $SwitchPort::OSS_SNMP_MAU_MAP were incorrectly capitalised.

Some mau* parameters pulled from snmp were not correctly cast to tinyint {0,1} before committing to DB.

In addition to the above, I have:

  • ensured all relevant template output is escaped to avoid XSS attached with <?= $t->ee( $data ) ?> or equivalent.
  • ensured appropriate checks against user privilege / resources accessed
  • API calls (particular for add/edit/delete/toggle) are not implemented with GET and use CSRF tokens to avoid CSRF attacks

@nickhilliard nickhilliard deleted the bf-snmpoll branch January 27, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants