Use a class for CachedMapper-derived mappers instead of a dict
#549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majosm
force-pushed
the
add-cache-class
branch
3 times, most recently
from
a34936a to
378d439
Compare
This was referenced Sep 24, 2024
majosm
force-pushed
the
add-cache-class
branch
3 times, most recently
from
1cf2454 to
df7db39
Compare
majosm
force-pushed
the
add-cache-class
branch
2 times, most recently
from
7b6df30 to
dec20c2
Compare
…t don't support functions
doesn't appear to be needed
the latter inflates recursion depth
majosm
force-pushed
the
add-cache-class
branch
from
dec20c2 to
d40153c
Compare
majosm
force-pushed
the
add-cache-class
branch
from
d40153c to
e9b4ac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds classes to represent the caches of
CachedMapper-derived mappers, which will be useful for adding array duplication checks and result deduplication (#550). Both of these features add additional cache dictionaries and cache retrieval/addition logic; this change minimizes the amount of logic that must be duplicated when mappers overriderec, as well as minimizes the extra arguments that need to be passed around for function caches when cloning new mappers.Depends on #531.