Fix compatibility with Python 3.13 #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
force-pushed
the
py3.13
branch
2 times, most recently
from
b6a9014
to
1f8c7ca
Compare
These were copy-pasted in from CPython in 6065d5a According to https://bugs.python.org/issue16482, where the patch originated, all supported versions of Python now have the fix. Additionally, Python 3.13 has further modifications, which we probably shouldn't copy.
This code dates from the very early days of Pudb, possibly copy-pasted from early pdb. No recent Python seems to have it, and on Py3.13 it is actively harmful, because its new frame locals proxy prohibits deletion of frame locals.
This makes the code a bit easier to follow, and it uses a more appropriate _set_stopinfo in the pause case, instead of set_step. Use of set_step was causing set_trace to stop somewhere in the guts of bdb. Closes gh-663
|
Ah well, it's probably better to have this than not. I'll merge and roll a release. |
|
The code here seems to be related to the work I did on unbreakpointing a set_trace line. I tested it in 3.9, 3.12, and 3.13 and it still seems to work. |
|
Thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues I've noticed with Python 3.13, which seems to contain quite a few changes to
bdb. This seems to work for me, but I'm not necessarily confident in these changes. See the commit messages for some explanation.I would love some testing from others before I release this.
@asmeurer @mvanderkamp Would you be willing to give this a look/test?