Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep lexigraphic sort ordering for this.stores #265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Keep lexigraphic sort ordering for this.stores #265

wants to merge 2 commits into from

Commits on Aug 16, 2017

  1. Keep hierarchy when updating store with use() function 

    Previously, when store were updated with `Provider.use()` function
it were moved as last in configuration hierarchy. This caused
that usually some other configuration were overriding updated
configurations and the updates never get applied.
Updated `use()` function to not remove/add the store, but just
re-define it so the store key keep the same position in the
`this.stores` variable.
    @ernoaapa
    ernoaapa authored and Matt Hamann committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    4d9364d View commit details
    Browse the repository at this point in the history

  2. [fix] Do not change lexigraphic ordering of keys in this.stores.

    @indexzero
    indexzero authored and Matt Hamann committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    bb07f1d View commit details
    Browse the repository at this point in the history