Actually add ae.sc, oe.sc and oslash.sc to lookups #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #30.
ctrlcctrlv
commented
Jan 10, 2023
Comment on lines
+183
to
+184
| sub \Oslash by \oslash.sc ; | ||
| sub \OE by \oe.sc ; |
There was a problem hiding this comment.
Just some missing substitutions. :-)
|
I think your issue is fixed @sigurdhasle
|
|
Thank you! My issue is (almost) fixed now! Now I even think i understand that «ae.sc, oe.sc and oslash.sc» means «small capitals æ, œ and ø». (Œ is the French version of the Norwegian ø.) The small caps are correct and beautiful now. If you can correct the small caps italics, too, I will be completely happy. |
|
are you sure? even as of 0b1cc55? |
|
also i don't recommend trying to use smallcaps in narrow or condensed, they're unsupoprted still :)
|
|
There it is! Perfect! Thank you very much! (And I will avoid to use small caps in narrow or condensed.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19.
Note: Assumes merger of #31. Merge #31 first then this.