Fix Cadence pipeline checks not starting #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ services: | |||
| networks: | |||
| - testing-network | |||
| zookeeper: | |||
| image: wurstmeister/zookeeper:3.4.6 | |||
| image: wurstmeister/zookeeper:latest | |||
There was a problem hiding this comment.
Thanks! I do notice that the latest version here was released 6 years ago
Should we start using the official zookeeper image instead? Is there a reason we're using the wurstmeister/zookeeper image?
There was a problem hiding this comment.
Yeah we should!
Last time I spent a few minutes trying out but it didn’t work. I didn’t got time to. Investigate.
There was a problem hiding this comment.
Cadence has upgraded their docker compose to use the official one. I think we should do that and also upgrade the cadence image to the 1.x release
There was a problem hiding this comment.
The reason was that cadence was using that kafka image and I just followed it
longquanzheng
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.