Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the breakingpoint to display legend in slide panel or on top of the map #672

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

kolok
Copy link
Contributor

@kolok kolok commented Jun 28, 2024

dans cette PR on modifie le point de rupture pour l'affichage de la légende comme un paneau apparaissan lors de l'appuie sur le bouton legends ou comme un ecart toujours visible :

CleanShot 2024-06-28 at 11 05 09

vs

CleanShot 2024-06-28 at 11 05 51

Reste à choisir avec @LuluFreeDesign quel est le point de rupture pour ce changement de comportement : md ou lg. Si lg est choisit il faudra modifier cette PR en conséquence.

@fabienheureux
Copy link
Member

@fabienheureux
Copy link
Member

Vu avec Lucas, on part sur lg

@fabienheureux fabienheureux marked this pull request as ready for review July 3, 2024 14:09
@fabienheureux fabienheureux requested a review from a team as a code owner July 3, 2024 14:09
@fabienheureux fabienheureux requested review from fabienheureux and removed request for a team July 3, 2024 14:09
@fabienheureux fabienheureux requested a review from Hazelmat July 3, 2024 14:10
@fabienheureux fabienheureux merged commit 72b8ca0 into main Jul 3, 2024
7 checks passed
@fabienheureux fabienheureux deleted the legend_breakpoint branch July 3, 2024 14:18
fabienheureux added a commit that referenced this pull request Jul 22, 2024
…f the map (#672)

* Update the breakingpoint to display legend in slide panel or on top of the map

* Update carte_header.html

* Update map_and_detail.html

---------

Co-authored-by: Fabien Le Frapper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants