Fix/refactor transactions #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearranged the project to use the Repository pattern to fetch each type from the YNAB API.
While a typical Repository implementation might have a separate class for each entity — Transaction, Payee, Category, Budget, Account — our we are only reading from the YNAB API at this point and we don’t need the increased complexity of separate repo classes for simple read-only operations. The read-only nature of this project is why the Repository pattern was chosen over alternatives.
Added tests & factories for the new repository methods.
The CacheRepository is stated in this PR as well, which was an oversight but It's 1:30 and I'm the only developer on this project so I'm going to merge it anyway.