Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissions UI Fix #1445

Closed
abhasinat opened this issue Apr 23, 2024 · 4 comments
Closed

Permissions UI Fix #1445

abhasinat opened this issue Apr 23, 2024 · 4 comments
Assignees
@budowski
Labels
Android Issues that are unique to Android bug Something isn't working UI Strictly about changing the appearance of things.
Milestone
Soft Launch / MVP

Comments

@abhasinat
Copy link

abhasinat commented Apr 23, 2024 •
edited
Loading

8

The background image on the permission screens should extend to the top & bottom of the screen.
@abhasinat abhasinat added the bug Something isn't working label Apr 23, 2024
@abhasinat abhasinat moved this to Todo in iNat Mobile Apr 23, 2024
@abhasinat abhasinat added this to the Soft Launch / MVP milestone Apr 23, 2024
@kueda
Copy link
Member

kueda commented Apr 23, 2024

But not the top?

@abhasinat
Copy link
Author

abhasinat commented Apr 23, 2024 •
edited
Loading

I think top would be good too, actually. Updated.

@kueda kueda added the UI Strictly about changing the appearance of things. label May 7, 2024
@budowski budowski self-assigned this Jun 4, 2024
@budowski
Copy link
Collaborator

OK, so the bottom part (navigation bar) and the top bar (status bar) cannot be fully hidden on Android when it's inside modals (and the permission gate is modal-based) - unless we do ugly patch-work directly on node-modules or use a forked version of RN (known issue with react-native):
kadiraydinli/react-native-system-navigation-bar#51

@kueda kueda added the Android Issues that are unique to Android label Jun 18, 2024
@kueda
Copy link
Member

kueda commented Jun 18, 2024

Sounds like it's not worth fixing until the react native bug gets fixed. We can re-open if we change our minds.

@kueda kueda closed this as not planned Won't fix, can't repro, duplicate, stale Jun 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in iNat Mobile Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budowski budowski

Labels
Android Issues that are unique to Android bug Something isn't working UI Strictly about changing the appearance of things.
Projects
iNat Mobile
Status: Done
Milestone
Soft Launch / MVP
Development

No branches or pull requests
3 participants
@kueda @budowski @abhasinat