Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parametrizes the default zoom stage of the plot #5

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

alpae
Copy link
Contributor

@alpae alpae commented Mar 27, 2020

benchmarkPlot_scatter div accepts an additional attribute
'default-zoom' that allows to set the initial zoom state. Accepted
value are either 'on' or 'true'. If not specified, the default is
to not zoom the plot.

@alpae
Copy link
Contributor Author

alpae commented Mar 27, 2020

feature needed for orthology benchmark service to address comments by David and Steve for revised manuscript

@alpae alpae force-pushed the parametrize-default-zoom-state branch from 86478fc to 3939d3c Compare December 12, 2021 14:51
@alpae
Copy link
Contributor Author

alpae commented Dec 12, 2021

Hi @dominikbruechner ,

I've updated this PR to the latest master branch. it allows to specify the default zoom state on the

element, e.g.

<div data-id="OEBD00200001HD" class="benchmarkingChart_scatter" default-zoom="on" data-api-url="https://dev-openebench.bsc.es/api/scientific/graphql"></div>

for our frontend, this is quite crucial, as some users requested different states for different benchmark challenges.
please let me know what you think about this change.

Cheers Adrian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants