Fixed validation and added support for Powermail 8/TYPO3 10 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deferred scripts should already be parsed when DomContnetLoaded gets fired.
The form id is no longer needed
Trigger the form submit (explicitely by clicking teh button again) after the gcaptcha response value has been set.
Despite being a known problem it only started to appear after an upgrade to PHP 7.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should repair HTML and client side validation (if enabled).
I refactored the Google reCaptcha v3 integration so that the reCaptcha challenge is programmatically invoked after HTML and client side validation.
The new integration does not need the Powermail form id anymore so I also removed the Form.html template to keep things DRY.
The form id usage didn't work anymore for Powermail 8/TYPO3 10 because of the pages -> page, forms -> form renaming anyway - so as a side effect the new implementation is compatible with Powermail 8/TYPO3 10.
This should solve Issues #3, #14, #15, #17 and probably #16.