Optimized the Search Function #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored the `MemorySource` struct in `memory.go` to include `referencesBySubjectDigest` - Updated the `NewMemorySource` function to initialize these new fields. - Modified the `LoadEnvelope` function to populate these new fields when loading an envelope. - Updated the `Search` function to use these new fields when searching for matching envelopes. - These changes improve the efficiency of the search operation by reducing the time complexity. Signed-off-by: neilnaveen <[email protected]>
|
@neilnaveen thank you once again for another PR 😄. I can see that you have certainly made the code more efficient, my only concern is on the side of the complexity of understanding how the maps are operating here with your changes implemented. I probably will need to pull this down and step through it before accepting. @mikhailswift any thoughts on the changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemorySourcestruct inmemory.goto includereferencesBySubjectDigestNewMemorySourcefunction to initialize these new fields.LoadEnvelopefunction to populate these new fields when loading an envelope.Searchfunction to use these new fields when searching for matching envelopes.