Add support for controller-gen deepcopy #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is will be required for archivista data provider controllers Signed-off-by: John Kjell <[email protected]>
| type Policy struct { | ||
| Expires time.Time `json:"expires"` | ||
| Expires metav1.Time `json:"expires"` |
There was a problem hiding this comment.
Does this affect the json marshalling/unmarshalling of this struct at all?
There was a problem hiding this comment.
Possibly? If it does, for the better I think. But, we probably won't notice. From the Kubebuilder book:
There’s one other special type that we use: metav1.Time. This functions identically to time.Time, except that it has a fixed, portable serialization format.
|
Ran witness's tests with these changes and the expiry date all works, so this lgtm! |
mikhailswift
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
controller-gendeepcopy of policy package structs. This will be required for archivista data provider controllers.