Test/more policy tests #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to fix a broken test before this is ready. Found more bugs adding tests. |
jkjell
force-pushed
the
test/more-policy-tests
branch
from
e6d650c
to
71d7cbb
Compare
Signed-off-by: Mikhail Swift <[email protected]>
Signed-off-by: Mikhail Swift <[email protected]>
jkjell
force-pushed
the
test/more-policy-tests
branch
from
7949d4a
to
8ae13c2
Compare
Signed-off-by: John Kjell <[email protected]>
jkjell
force-pushed
the
test/more-policy-tests
branch
from
1a3d560
to
5bb1527
Compare
|
just read @jkjell's changes through a couple of times. I think they look fine / sane to me. Maybe best to get a second pass from @mikhailswift though. |
ChaosInTheCRD
approved these changes
Oct 10, 2024
|
Yeah, the added commit seems reasonable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Description
Which issue(s) this PR fixes (optional)
(optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged)*Fixes #
Acceptance Criteria Met
Special notes for your reviewer: