Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better concurrency support on Linux #306

Merged
merged 6 commits into from
Jul 31, 2024
Merged

better concurrency support on Linux #306

merged 6 commits into from
Jul 31, 2024

Conversation

joshdabosh
Copy link
Contributor

What this PR does / why we need it

  • When ptracing programs, restrict the product attestor to only attest for files recorded as "opened" by the commandrun attestor. Then, files created by a separate process running concurrently will not be mistakenly included in the attestation products (this happens currently).
  • Keep track of newly created files when tracing with ptrace. Previously, they would not be added to the OpenedFiles list because the file would not exist when attempting to calculate its digest.

Which issue(s) this PR fixes (optional)

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

@mikhailswift
Copy link
Member

Hi @joshdabosh, thanks for this contribution! I'll start testing this and give you a review shortly.

@mikhailswift
Copy link
Member

Just the one minor nit, otherwise I think this is good to go!

@jkjell jkjell merged commit 3f491a3 into in-toto:main Jul 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants