Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attestors to have multiple types #277

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Allow attestors to have multiple types #277

merged 1 commit into from
Jun 13, 2024

Conversation

jkjell
Copy link
Member

@jkjell jkjell commented Jun 13, 2024

What this PR does / why we need it

This will allow the SBOM attestor, and future attestors, to support multiple types for a single attestor. In the case of the SBOM attestor, we'd like to record the appropriate type for SPDX, CycloneDX, etc without having to implement a different attestor for the same functionality.

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

colek42
colek42 previously approved these changes Jun 13, 2024
Copy link
Member

@colek42 colek42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkjell jkjell merged commit 9f32585 into main Jun 13, 2024
16 checks passed
@jkjell jkjell deleted the attestor-multi-type branch June 13, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants