Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add git refs to go witness git attestor #265

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

kriscoleman
Copy link
Contributor

@kriscoleman kriscoleman commented Jun 5, 2024

What this PR does / why we need it

this enables witness to track git refs

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:
This does not retroactively add git refs to existing attestations.
Only new attestations would generate git-refs in them after these changes are merged.

@kriscoleman kriscoleman marked this pull request as ready for review June 5, 2024 19:51
kriscoleman and others added 2 commits June 5, 2024 17:05
this enables witness to track git refs

Co-authored-by: Nick Kane <[email protected]>
Signed-off-by: Kris Coleman <[email protected]>
Copy link
Member

@jkjell jkjell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @kriscoleman and @nkane!

@jkjell jkjell merged commit 9500022 into in-toto:main Jun 6, 2024
12 checks passed
@jkjell jkjell deleted the chore/[email protected] branch June 6, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants