Parallel attestors per type #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks again for another PR! I seem to recall that there was a reason why we opted to not run attestors in parallel 🤔 @mikhailswift @jkjell any ideas? |
matglas
commented
May 1, 2024
matglas
changed the title
matglas
force-pushed
the
parellel-attestors
branch
from
c6ce25b
to
f55352f
Compare
matglas
force-pushed
the
parellel-attestors
branch
2 times, most recently
from
d6e84d4
to
9a7c085
Compare
matglas
force-pushed
the
parellel-attestors
branch
2 times, most recently
from
cbdd6fd
to
cf5b45e
Compare
jkjell
force-pushed
the
parellel-attestors
branch
from
cf5b45e
to
88a01f4
Compare
jkjell
approved these changes
Jun 1, 2024
There was a problem hiding this comment.
Given the scope of the changes, I'll wait for a second approval from @ChaosInTheCRD or @mikhailswift before merging.
Signed-off-by: Matthias Glastra <[email protected]>
jkjell
force-pushed
the
parellel-attestors
branch
from
88a01f4
to
7ce62a0
Compare
|
Nice thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing per attestor type to run all the attestors in parallel to speed up the process.