Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Migrating Go module to in-toto #101

Merged
merged 7 commits into from
Dec 14, 2023

Conversation

ChaosInTheCRD
Copy link
Collaborator

This PR is to change the name of the module and all imports inside it to reflect the projects new location at github.com/in-toto/go-witness.

I've tried my best to catch every use of testifysec/go-witness but this will probably need some more validation / testing.

@ChaosInTheCRD
Copy link
Collaborator Author

This will fail for now as we are waiting for merging of in-toto/archivista#121

@ChaosInTheCRD ChaosInTheCRD requested a review from jkjell December 13, 2023 17:16
Copy link
Member

@jkjell jkjell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we remove the archivista package changes we can hopefully at least get tests running.

archivista/download.go Show resolved Hide resolved
archivista/searchgitoids.go Show resolved Hide resolved
archivista/store.go Show resolved Hide resolved
@ChaosInTheCRD
Copy link
Collaborator Author

So CI is going to continue failing on this PR as the old archivista-api module refers to the old go-witness module. I suppose this will just wait until in-toto/archivista#121 is merged?

jkjell
jkjell previously approved these changes Dec 14, 2023
@jkjell jkjell dismissed their stale review December 14, 2023 05:16

Accidental approval

@ChaosInTheCRD
Copy link
Collaborator Author

@jkjell just to confirm, the current state is that we are depending on the main branch of https://github.com/in-toto/archivista and we will remove this dependency back to the next release when that is cut?

@jkjell jkjell merged commit 5b5647c into in-toto:main Dec 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants