Refactoring services #287
Merged
Refactoring services #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kairoaraujo
force-pushed
the
refactoring_services
branch
from
4db95b6 to
b638f15
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
==========================================
- Coverage 82.40% 1.61% -80.80%
==========================================
Files 10 119 +109
Lines 358 28846 +28488
==========================================
+ Hits 295 465 +170
- Misses 43 28324 +28281
- Partials 20 57 +37 ☔ View full report in Codecov by Sentry. |
kairoaraujo
force-pushed
the
refactoring_services
branch
from
7e5065b to
e363876
Compare
|
@jkjell rebased. |
Remove the internal in order to enable Archivista source code user to: - Extend/Modify the existent services (config, storage, etc) within their code base - Allow to use Archivista encapuslated in other services, example API service Signed-off-by: Kairo Araujo <[email protected]>
Simplifies Archivista main cmd moving all the service logic into the `pkg/server`. It allows users to use the Archivista Server instance as an Service Interface allowing to integrate along to API services. Signed-off-by: Kairo Araujo <[email protected]>
jkjell
force-pushed
the
refactoring_services
branch
from
e363876 to
eb2c383
Compare
jkjell
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
It simplifies Archivista's main cmd by moving all the service logic into the
pkg/server.It allows users to use the Archivista Server instance as a Service Interface and allows integration along with API services.
Remove the internal to enable Archivista source code user to:
Extend/Modify the existent services (config, storage, etc) within
their code base
Allow the use of Archivista encapsulated in other services, for example, API service
Acceptance Criteria Met
Special notes for your reviewer: