500 cigarettes made rarer #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
500 cigarettes is a ruined joke. Not a shift goes by without an uncleanable amount of cigarettes littering the station because it's trivial to get. By moving it to the emag inventory, it's now a toy available to only cargo and antag instead of literally everyone. The rarity makes it more special when it's seen.
The other aspect is lag. The item creates 500 entities, often located very close together. The engine doesn't like loading more than 50 things at a time according to wizden, and while it's not a problem on its can certainly contribute.
🆑 aada