Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port stock market from Delta-V #1314

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

EpicToastTM
Copy link

@EpicToastTM EpicToastTM commented Jan 11, 2025

Adds the StockTrading cartridge from Delta-V (DeltaV-Station/Delta-v#2103). It starts installed on quartermaster and cargo technician PDAs (sorry salvage), and the cartridge can be found in the quartermaster's locker. The app requires cargo access to use and prices update every five minutes.

Admins can also add custom companies or change stock values themselves with addstockscompany and changestockprice.

image

Changelog
🆑EpicToast

  • add: Add the StockTrading cartridge. Starts installed on QM and cargo tech PDAs and can be found in the QM's locker.

@hivehum
Copy link

hivehum commented Jan 11, 2025

scope creep can you make the cartridge a thief target

edit: also i dont really love using dollar signs to denote spesos. can you use a different thing. § like simoleons

@EpicToastTM
Copy link
Author

hell yea (to both of those)

@EpicToastTM
Copy link
Author

wahhhh my linter

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im sorry but this sprite is kind of fucking ugly

mqole
mqole previously requested changes Jan 13, 2025
Copy link

@mqole mqole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good... once the tag is added to the cartridge we can merge
happy to make a custom sprite for the thingy
is the whitespace still sucks? yamllinter seems happy

EDIT OH im a moron who cant view edited commits. ok. please wait warmly

@mqole
Copy link

mqole commented Jan 13, 2025

ACTUAL CHANGES

accessibility: could you give the 'amount' bar a default value of 1?
image

please also add basecargocontraband to the stocktrading cartridge

@EpicToastTM
Copy link
Author

image

i'm a little worried that the purpose of the amount field isn't clear anymore, but here's those changes

@formlessnameless formlessnameless dismissed mqole’s stale review January 14, 2025 23:49

lg2m, the changes are made

@formlessnameless formlessnameless merged commit a14784c into impstation:master Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants